Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds initial support (backend implementation + unit tests) for the Veritas Access Cinder volume charm/backend.
Changes:
- Introduces a new
veritasaccessstorage backend and its Pydantic config model. - Adds a dedicated unit test module for the new backend/config validation.
- Extends shared backend test fixtures and “all backends” assertions to include
veritasaccess.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sunbeam-python/sunbeam/storage/backends/veritasaccess/backend.py | New Veritas Access backend implementation and config schema. |
| sunbeam-python/sunbeam/storage/backends/veritasaccess/init.py | New backend package initializer/docstring. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/test_veritasaccess.py | New unit tests for backend identity and protocol validation. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py | Includes veritasaccess in shared uniqueness/expectation tests. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py | Adds veritasaccess_backend fixture and includes it in parametrized backend fixture. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ahmad-can
force-pushed
the
feature/generate-veritasaccess-charm
branch
from
d3fe805 to
1bdeb43
Compare
ahmad-can
force-pushed
the
feature/generate-veritasaccess-charm
branch
from
1bdeb43 to
10c075f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Charm https://review.opendev.org/c/openstack/sunbeam-charms/+/984537